feat: Add wasm_memory_limit to the management canister
#483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `wasm_memory_limit` to `CanisterSettings` and `DefiniteCanisterSettings`. The corresponding spec change: - dfinity/interface-spec#278
lwshang
approved these changes
Apr 19, 2024
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Oct 8, 2024
Relevant breaking changes from [`ic-cdk`](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md): 1. [[0.15.0]]([0.15.0]): 1. BREAKING: Stable Memory always use 64-bit addresses and stable64_* system API. (dfinity/cdk-rs#498) 2. BREAKING: Add log_visibility to the management canister API types: (dfinity/cdk-rs#497) - CanisterSettings - DefiniteCanisterSettings. 3. [[0.13.3]](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md#0133---2024-05-10-yanked) BREAKING: Add wasm_memory_limit to the management canister API types: (dfinity/cdk-rs#483) - CanisterSettings - DefiniteCanisterSettings. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
nikolay-komarevskiy
pushed a commit
to dfinity/ic
that referenced
this pull request
Oct 11, 2024
Relevant breaking changes from [`ic-cdk`](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md): 1. [[0.15.0]]([0.15.0]): 1. BREAKING: Stable Memory always use 64-bit addresses and stable64_* system API. (dfinity/cdk-rs#498) 2. BREAKING: Add log_visibility to the management canister API types: (dfinity/cdk-rs#497) - CanisterSettings - DefiniteCanisterSettings. 3. [[0.13.3]](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md#0133---2024-05-10-yanked) BREAKING: Add wasm_memory_limit to the management canister API types: (dfinity/cdk-rs#483) - CanisterSettings - DefiniteCanisterSettings. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
wasm_memory_limittoCanisterSettingsandDefiniteCanisterSettings.The corresponding spec change:
Ticket: SDK-1588