Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NPR lib to NPR App #1074

Merged
merged 24 commits into from
Nov 11, 2024
Merged

Add NPR lib to NPR App #1074

merged 24 commits into from
Nov 11, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Nov 11, 2024 •
edited
Loading

This adds the NPR library to the NPR canister removing the rewards computation from the canister itself.
Other changes included in the PR:

  • Add CandidType to result structs of the lib.
  • Add log level for RewardsLog to not always print entire execution
  • Remove unused in canister logger

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner November 11, 2024 17:51
sasa-tomic
sasa-tomic approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 2621782 into main Nov 11, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the adapt-npr-app-for-new-lib branch November 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrodimarco-dfinity @sasa-tomic