fix: refine cycles cost calculation #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Jan 23, 2024
Comment on lines
+17
to
+18
| (EvmRpcCanister, "default", 13, 61_898_400), | ||
| (EvmRpcFidicuaryCanister, "fiduciary", 28, 133_319_630), |
There was a problem hiding this comment.
I think we should document somewhere how these numbers are derived.
Maybe such details could be discussed on a wiki page (which the EVM RPC canister should definitely get). What do you think?
There was a problem hiding this comment.
Definitely. The calculation for these numbers is explained in the design document, which we could transfer to a wiki page.
THLO
approved these changes
Jan 23, 2024
…ic-eth-rpc into refine-cycles-cost-calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cycles cost calculation slightly overcharges for request bytes (10400 instead of 5200), so this PR separates the costs of request and response bytes.