auth: miscellaneous #160
Merged
auth: miscellaneous #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
changed the title
THLO
reviewed
Jan 30, 2024
src/auth.rs
Outdated
| let principal = PrincipalStorable(principal); | ||
| let mut auth_set = auth_map.get(&principal).unwrap_or_default(); | ||
| let changed = auth_set.authorize(auth); | ||
| auth_map.insert(principal, auth_set); |
There was a problem hiding this comment.
This insert does nothing really if changed = false, right?
There was a problem hiding this comment.
That's correct; updated the code for clarity.
THLO
reviewed
Jan 30, 2024
| PROVIDERS.with(|providers| { | ||
| let mut providers = providers.borrow_mut(); | ||
| match providers.get(&args.provider_id) { | ||
| Some(mut provider) => { | ||
| if provider.owner != caller { | ||
| if !(provider.owner == caller || is_controller) { |
There was a problem hiding this comment.
The trap message needs to be updated. Shouldn't it simply be "You are not authorized" as above?
There was a problem hiding this comment.
You're right; thanks. Trying to do too many things at the same time, haha. Updated with additional text to distinguish cases where the owner has authorization.
THLO
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_authorizeanddo_deauthorize