refactor: move GetLogsArgs and LogEntry to the evm_rpc_types crate
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Aug 27, 2024
THLO
reviewed
Aug 27, 2024
THLO
approved these changes
Aug 27, 2024
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #257 to move the types
GetLogsArgsandLogEntryto theevm_rpc_typescrate, so that the public API ofeth_get_logsonly uses types from that crate.Additionally, add the types
Hex,Hex20, andHex32as a transparent wrapper around a Candid typetextto represent Ethereum hex strings (prefixed by0x) containing an unbounded, 20 or 32 bytes, respectively.