Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move TransactionReceipt to evm_rpc_types #263

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Aug 28, 2024

Follow-up on #257 to move the type TransactionReceipt to the evm_rpc_types crate, so that the public API of eth_get_transaction_receipt only uses types from that crate.

@gregorydemay gregorydemay linked an issue Aug 28, 2024 that may be closed by this pull request
@gregorydemay gregorydemay marked this pull request as ready for review August 28, 2024 13:52
@gregorydemay gregorydemay requested review from rvanasa and THLO August 28, 2024 13:52
evm_rpc_types/CHANGELOG.md Outdated Show resolved Hide resolved
evm_rpc_types/src/response/mod.rs Show resolved Hide resolved
evm_rpc_types/src/response/mod.rs Show resolved Hide resolved
src/candid_rpc.rs Show resolved Hide resolved
src/candid_rpc/cketh_conversion.rs Show resolved Hide resolved
tests/tests.rs Show resolved Hide resolved
@gregorydemay gregorydemay merged commit 30cccbe into main Aug 29, 2024
3 checks passed
@gregorydemay gregorydemay deleted the gdemay/243-tx-receipt-evm-rpc-types branch August 29, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to remove cketh-minter dependency
3 participants