Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Block to evm_rpc_types #268

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Sep 10, 2024

Follow-up on #257 to move the type Block to the evm_rpc_types crate, so that the public API of eth_get_block_by_number only uses types from that crate.

@gregorydemay gregorydemay linked an issue Sep 10, 2024 that may be closed by this pull request
@gregorydemay gregorydemay marked this pull request as ready for review September 10, 2024 15:17
Copy link
Collaborator

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

evm_rpc_types/src/response/mod.rs Show resolved Hide resolved
@rvanasa
Copy link
Collaborator

rvanasa commented Sep 10, 2024

(Pushed a trailing newline from cargo fmt to pass CI)

@gregorydemay gregorydemay merged commit a98a9bf into main Sep 11, 2024
3 checks passed
@gregorydemay gregorydemay deleted the gdemay/243-block-evm-rpc-types branch September 11, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to remove cketh-minter dependency
3 participants