refactor: move types related to providers to evm-rpc-types crate
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
commented
Sep 12, 2024
| @@ -35,17 +30,23 @@ struct CanisterTransport; | |||
| #[cfg_attr(target_arch = "wasm32", async_trait(?Send))] | |||
| #[cfg_attr(not(target_arch = "wasm32"), async_trait)] | |||
| impl RpcTransport for CanisterTransport { | |||
There was a problem hiding this comment.
This trait is currently defined in cketh_common and that's why we need to still types from that crate here.
rvanasa
approved these changes
Sep 12, 2024
# Conflicts: # src/types.rs # tests/tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #257 to move the following types to the
evm_rpc_typescrate:EthMainnetServiceEthSepoliaServiceHttpHeaderL2MainnetServiceRpcApiRpcConfigRpcServiceRpcServicesso that the public API of all methods in
main.rsonly use types from that crate as arguments.