Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move types related to result to evm-rpc-types #274

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Sep 13, 2024

Follow-up on #257 to move the following types to the evm_rpc_types crate:

  1. HttpOutcallError
  2. JsonRpcError
  3. MultiRpcResult
  4. ProviderError
  5. RpcError,
  6. RpcResult
  7. ValidationError

so that the public API of all methods in main.rs only use types from that crate as return types.

@gregorydemay gregorydemay marked this pull request as ready for review September 13, 2024 08:44
@gregorydemay gregorydemay force-pushed the gdemay/243-result-evm-rpc-types branch from 9f921e1 to 9eb8b90 Compare September 13, 2024 09:42
@gregorydemay gregorydemay merged commit 476e489 into main Sep 16, 2024
6 checks passed
@gregorydemay gregorydemay deleted the gdemay/243-result-evm-rpc-types branch September 16, 2024 07:20
@gregorydemay gregorydemay linked an issue Sep 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to remove cketh-minter dependency
2 participants