refactor: consolidate JSON requests and responses #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
changed the title
THLO
approved these changes
Sep 17, 2024
rvanasa
approved these changes
Sep 17, 2024
# Conflicts: # Cargo.toml # src/candid_rpc/cketh_conversion.rs # src/main.rs # src/rpc_client/checked_amount/mod.rs # src/rpc_client/eth_rpc/mod.rs # src/rpc_client/eth_rpc/tests.rs # src/rpc_client/eth_rpc_error/mod.rs # src/rpc_client/mod.rs # src/rpc_client/tests.rs
Merged
gregorydemay
added a commit
that referenced
this pull request
Sep 20, 2024
Follow-up on #279 to move JSON types into `src/rpc_client/json` and remove some unused code.
gregorydemay
added a commit
that referenced
this pull request
Oct 3, 2024
Fix a bug introduced by #279, where the constant `HTTP_MAX_SIZE` was changed from 2 MB to 2 MiB. This is wrong since per the [IC specification ](https://internetcomputer.org/docs/current/references/ic-interface-spec#ic-http_request) `max_response_bytes` must be at most `2_000_000` bytes and HTTPs outcalls using a bigger value for `max_response_bytes` will be rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #275 to move JSON rpc requests to
src/rpc_client/json/requests.rsand responses tosrc/rpc_client/json/responses.rs