refactor: use evm_rpc_types in Rust E2E canister
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
commented
Oct 2, 2024
rvanasa
changed the title
evm_rpc_types in Rust E2E canisterevm_rpc_types in Rust E2E canister
rvanasa
changed the title
evm_rpc_types in Rust E2E canisterevm_rpc_types in Rust E2E canister
rvanasa
commented
Oct 2, 2024
Comment on lines
+13
to
+19
| #[cfg(target_arch = "wasm32")] | ||
| const CANISTER_ID: Option<&str> = Some(std::env!( | ||
| "CANISTER_ID_EVM_RPC_STAGING", | ||
| "Unspecified canister ID environment variable" | ||
| )); | ||
| #[cfg(not(target_arch = "wasm32"))] | ||
| const CANISTER_ID: Option<&str> = None; |
There was a problem hiding this comment.
This removes the environment variable error in the IDE and when running cargo test, although maybe there is a nicer way to do this.
gregorydemay
approved these changes
Oct 3, 2024
gregorydemay
force-pushed
the
evm-rpc-types-rust-e2e
branch
from
14295c5 to
5710470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #294 (comment).