Skip to content

Commit

Permalink
Add banner bg variable (#557)
Browse files Browse the repository at this point in the history
# Motivation

To solve the low contrast of the banners in cards and standardize their
appearance, a new color theme variable has been added.

# Changes

- Added `--banner-background` to both themes.

# Screenshots

| Before | After |
|--------|--------|
| <img width="792" alt="image"
src="https://github.com/user-attachments/assets/cae9911b-b076-44de-b1dc-0ab9643b391d"
/> | <img width="786" alt="image"
src="https://github.com/user-attachments/assets/fe88b1a8-3721-4445-9b99-064796e2d050"
/> |
| <img width="777" alt="image"
src="https://github.com/user-attachments/assets/6583d802-b434-4a9e-ab19-e73f882cf454"
/> | <img width="779" alt="image"
src="https://github.com/user-attachments/assets/931df786-fe04-4b35-9cd7-e8b25ec8368e"
/> |
| <img width="1176" alt="image"
src="https://github.com/user-attachments/assets/7cb46733-8d86-4442-8175-d1374eeee8b0"
/> | <img width="1175" alt="image"
src="https://github.com/user-attachments/assets/796af1bb-d75f-47e1-8246-9fb813bcf741"
/> |
| <img width="1166" alt="image"
src="https://github.com/user-attachments/assets/fad8defb-dc8a-4fb9-8c43-1c749df6651c"
/> | <img width="1174" alt="image"
src="https://github.com/user-attachments/assets/ba9f453d-f64a-4861-b838-1c6f298b624d"
/> |
  • Loading branch information
mstrasinskis authored Dec 23, 2024
1 parent 73c97ef commit 12d5bac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/lib/styles/themes/dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -231,4 +231,6 @@
--tag-executed-background: var(--orchid-200-a25);
--tag-failed-text: var(--orange-200);
--tag-failed-background: var(--orange-200-a25);

--banner-background: var(--card-background-tint);
}
2 changes: 2 additions & 0 deletions src/lib/styles/themes/light.scss
Original file line number Diff line number Diff line change
Expand Up @@ -241,5 +241,7 @@
--tag-executed-background: var(--orchid-200-a25);
--tag-failed-text: var(--orange-200);
--tag-failed-background: var(--orange-200-a25);

--banner-background: var(--card-background-tint);
}
}

0 comments on commit 12d5bac

Please sign in to comment.