Fix: Do not disconnect before update #141
Conversation
|
@peterpeterparker please review Was the reason to disconnect before update only to avoid a layout shift? I found a bug on mainnet that it's not requesting the voting history in the neuron details page. I was able to replicate it by:
|
|
As described in code
i.e. we do not want to trigger unnecessary query and update on proposal list views. This is particularly useful when the filter "hide proposals were I already voted" is selected. |
|
The problem was that the observer somehow didn't connect again then... I'll keep playing, but have you replicated the issue in mainnet? |
|
Not yet, I'll have a look tomorrow or next week |
|
ok, no worries. |
|
@lmuntaner thanks for the reproduction details, very useful 👍 I found the root cause of the issue and implemented a workaround so that it preserves the existing feature which is useful for the "Proposal list" view 👉 #142 Therefore I close this PR but for sure reopen it if I am missing something. |
|
@peterpeterparker thank you, that's perfect! |
…n bindings are used (#142) # Motivation We disable the `<InfiniteScroll />` component `beforeUpdate` because we do want to trigger an intersection in case of layout shifting - i.e. we do not want to trigger additional unexpected query and update calls in the proposal list views. We noticed that under certain circumstances, notably when initialized while enabling at the same time, a race condition can lead to the scroller being disabled. Root cause of the problem is a Svelte issue [#6016](sveltejs/svelte#6016). Indeed, when bindings are used (`bind:this=my_HTML_element`) within the compoment, the `beforeUpdate` lifecycle is called twice while `afterUpdate` is called only once. Therefore, as we disable the scroll in the first method and enable in the second, the scroller remains disabled. # Reproduction See PR #141 [comment](#141 (comment)). # Changes - implement a workaround to ignore second `beforeUpdate` call trigger by binding initialization
Motivation
InfiniteScroll didn't trigger intersection always.
Changes