Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SplitBlock component #299

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Add SplitBlock component #299

merged 7 commits into from
Oct 4, 2023

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Add SplitBlock component to use on full-content-width pages.

Changes

New component

Screenshots

image image

src/lib/components/SplitBlock.svelte Outdated Show resolved Hide resolved
src/lib/components/SplitBlock.svelte Outdated Show resolved Hide resolved
src/lib/components/SplitBlock.svelte Outdated Show resolved Hide resolved
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an e2e test?

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

src/lib/components/SplitBlock.svelte Outdated Show resolved Hide resolved
@mstrasinskis mstrasinskis requested a review from lmuntaner October 4, 2023 09:24
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstrasinskis mstrasinskis merged commit d322d0a into main Oct 4, 2023
@mstrasinskis mstrasinskis deleted the feat/split-block-component branch October 4, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants