Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix vulnerability issues #300

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

lmuntaner
Copy link
Collaborator

Motivation

Fix security issues.

Changes

Only automatic changes after running npm audit fix

Screenshots

No changes.

@lmuntaner
Copy link
Collaborator Author

@peterpeterparker please review

They were brought up by a security issue: https://dfinity.atlassian.net/browse/SCAVM-631

@peterpeterparker
Copy link
Member

Have you try to bump vitest to see if it solves the issue? We are behind, last release is v0.34.6

npm rm vitest && npm i vitest -D?

@lmuntaner
Copy link
Collaborator Author

Have you try to bump vitest to see if it solves the issue? We are behind, last release is v0.34.6

npm rm vitest && npm i vitest -D?

Yes, the issue seems fixed, but the test don't run anymore:

Error: Failed to resolve entry for package "@sveltejs/package". The package may have incorrect main/module/exports specified in its package.json: No known conditions for "." specifier in "@sveltejs/package" package

And I found this issue in vitest repo: vitest-dev/vitest#4194

I felt to first manage the security issue and we can consider upgrading vitest in another moment. WDYT?

@peterpeterparker
Copy link
Member

Gotcha

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@lmuntaner lmuntaner merged commit 9355d82 into main Oct 3, 2023
6 checks passed
@lmuntaner lmuntaner deleted the chore_LM_fix-security-issue branch October 3, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants