Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tell Vitest to use the browser entry points in package.json #551

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

I'm not sure we realy needs it but Svelte is advising to tell Vitest to use the browser entry points in package.json for the configuration of the test. Since I'm reviewing the configuration of the repo while migrating to Svelte v5, I think it's good to align this as well.

Source: https://svelte.dev/docs/svelte/testing#Unit-and-integration-testing-using-Vitest-Component-testing

Changes

  • Set condition equals to browser in resolve for Vitest.

@peterpeterparker peterpeterparker requested review from a team as code owners December 10, 2024 08:42
@peterpeterparker peterpeterparker merged commit 1cd00a2 into main Dec 10, 2024
8 checks passed
@peterpeterparker peterpeterparker deleted the chore/vitest-config branch December 10, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants