Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ic-http-gateway): TT-416 Add asset streaming via range requests #20

Merged
merged 5 commits into from
Sep 5, 2024
Merged

feat(ic-http-gateway): TT-416 Add asset streaming via range requests #20

merged 5 commits into from
Sep 5, 2024

Conversation

przydatek
Copy link
Contributor

@przydatek przydatek commented Aug 28, 2024 •
edited by jira bot
Loading

TT-416
Orchestrate streaming requests and responses of large assets according to Range-responses served by a caniser : instead of using StreamingStrategy-tokens from canister responses, use the range-headers from HTTP headers of the responses.

@przydatek przydatek marked this pull request as ready for review September 2, 2024 11:56
@przydatek przydatek requested a review from a team as a code owner September 2, 2024 11:56
nathanosdev
nathanosdev reviewed Sep 4, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
examples/http-gateway/canister/src/custom_assets/src/lib.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/mod.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/response/response_handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/response/response_handler.rs Show resolved Hide resolved
packages/ic-http-gateway/src/response/response_handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/tests/range_request_stream.rs Outdated Show resolved Hide resolved
przydatek
przydatek commented Sep 5, 2024
View reviewed changes
Copy link
Contributor Author

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, PTAL.

Cargo.toml Outdated Show resolved Hide resolved
examples/http-gateway/canister/src/custom_assets/src/lib.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/protocol/mod.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/response/response_handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/tests/range_request_stream.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/response/response_handler.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/src/response/response_handler.rs Show resolved Hide resolved
@nathanosdev nathanosdev merged commit 11492ae into main Sep 5, 2024
3 checks passed
@nathanosdev nathanosdev deleted the bartosz/range-streams branch September 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanosdev nathanosdev nathanosdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@przydatek @nathanosdev