-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --silent to npm pack
#668
Conversation
@dskloetd @peterpeterparker please review |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Are you sure those commands aren't output on stderr instead of stdout? Not outputing JSON when |
We found an issuer reporting it, and they considered it as fixed with the |
Motivation
@frederikrothenberger discovered that the outupt of
npm pack
is different depending on the npm version.Later versions of
npm
output some commands. Adding--silent
ensures that the output is a valid JSON without the commands.Changes
--silent
topublish-npm.sh
.Tests
Tested manually.
Todos