Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change InstallCode converters to be more consistent with other action… #688

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Change InstallCode converters to be more consistent with other action… #688

merged 1 commit into from
Jul 31, 2024

Conversation

jasonz-dfinity
Copy link
Contributor

@jasonz-dfinity jasonz-dfinity commented Jul 31, 2024 •
edited
Loading

Motivation

Change InstallCode converters to be more consistent with other action types

Changes

  • CanisterInstallMode is converted to an enum in defined in the governance.enums.ts
  • The 2 fields that might be large are no longer converted for responses, similar as ExecuteNnsFunction::payload

Tests

Unit tests

Changelog

Not adding to changelog because it already has a related entry. This PR improves it.

@jasonz-dfinity jasonz-dfinity requested review from a team as code owners July 31, 2024 05:13
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.9 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 36.26 KB (-0.27% 🔽)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.71 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.78 KB (0%)

mstrasinskis
mstrasinskis approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jasonz-dfinity jasonz-dfinity merged commit 2cb316f into main Jul 31, 2024
11 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/install-code-converters branch July 31, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonz-dfinity @mstrasinskis