Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update candid files #691

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Aug 5, 2024

Motivation

The canisters APIs have been updated.
Based on the bot pr - #690

Changes

  • Update the listNeurons interface. Follow the same logic as for includeEmptyNeurons (expecting the new field include_public_neurons_in_full_neurons to be not yet supported by the Ledger API).
  • npm run docs.

Tests`

  • Unit tests were adjusted and extended to support the new field.

Todos

  • Add entry to changelog (if necessary).

Copy link
Contributor

github-actions bot commented Aug 5, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.9 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 36.32 KB (+0.17% 🔺)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.71 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.78 KB (0%)

@mstrasinskis mstrasinskis marked this pull request as ready for review August 5, 2024 17:05
@mstrasinskis mstrasinskis requested review from a team as code owners August 5, 2024 17:05
packages/nns/src/governance.canister.ts Outdated Show resolved Hide resolved
packages/ckbtc/candid/minter.did Outdated Show resolved Hide resolved
Copy link
Collaborator

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstrasinskis mstrasinskis merged commit c168456 into main Aug 6, 2024
11 checks passed
@mstrasinskis mstrasinskis deleted the mstr/update-candid-files-2024-08-05 branch August 6, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants