Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update niv-updater-action to v6 #1689

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

knl
Copy link
Contributor

@knl knl commented Jul 7, 2020

Various fixes in the output, to make it more correct, and avoid spamming
of GitHub histories. Should be faster, too.

This release brings the following:

Formatting:

  • Fix: Add an empty line after the title. Now GitHub Commits list looks
    better.
  • Fix: Remove preceeding space in the title
  • Output branch name used by niv, so that it is clear what is being
    tracked
  • Add a title prefix support via title_prefix option

Being nice:

Performance:

  • Replace the use of jo with jq, thus avoiding to install jo
  • Do not install hub CLI, as it is present in the default image. This
    should avoid installing hub, speeding up the start.

Various fixes in the output, to make it more correct, and avoid spamming
of GitHub histories. Should be faster, too.

This release brings the following:

Formatting:
* Fix: Add an empty line after the title. Now GitHub Commits list looks
  better.
* Fix: Remove preceeding space in the title
* Output branch name used by niv, so that it is clear what is being
  tracked
* Add a title prefix support via `title_prefix` option

Being nice:
* Reformat mentions in the changelog to reduce spamming of mentioned
  developers (now, @knl will not generate a GitHub notification when
  present in the changelog)
* Add option to avoid GitHub backreferencing the PR. That is, when we
  have #123 in the changelog, it will be a correct link to the correct
  repository, however, the referenced PR/issue will not contain a
  reference, thus reducing the spamming. See
  knl/niv-updater-action#26 for more details.
* Make the location of `sources.json` customizable

Performance:
* Replace the use of jo with jq, thus avoiding to install jo
* Do not install hub CLI, as it is present in the default image. This
  should avoid installing hub, speeding up the start.
@knl knl requested a review from nomeata July 7, 2020 19:37
@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@nomeata nomeata merged commit a18e7c0 into master Jul 7, 2020
@nomeata nomeata deleted the update-niv-updater-action branch April 30, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants