Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta subdomains #5236

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Add beta subdomains #5236

merged 2 commits into from
Jul 25, 2024

Conversation

dskloetd
Copy link
Contributor

Motivation

We want to be able to deploy unreleased versions of the NNS dapp which can be used with the same mainnet principal as the real NNS dapp.

This PR is based on #3255

Changes

  1. Add the domains to .well-known/ic-domains so that the boundary node can see that the canister wants to serve on those domains.
  2. Add the domains to .well-known/ii-alternative-origins so the internet identity known those domains are allowed to use the same derivation origin.
  3. Add the domains to NNS_IC_ORG_ALTERNATIVE_ORIGINS so that nns-dapp knows to request the canonical derivation origin from internet identity when serving from those domains.

Tests

  1. Unit tests added.
  2. Downloaded https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/.well-known/ic-domains and got
nns.internetcomputer.org
wallet.internetcomputer.org
wallet.ic0.app
beta.nns.internetcomputer.org
beta.nns.ic0.app
  1. Downloaded https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/.well-known/ii-alternative-origins and got
{"alternativeOrigins": ["https://nns.internetcomputer.org", "https://wallet.internetcomputer.org", "https://wallet.ic0.app", "https://beta.nns.internetcomputer.org", "https://beta.nns.ic0.app"]}

Todos

  • Add entry to changelog (if necessary).

@dskloetd dskloetd marked this pull request as ready for review July 24, 2024 17:20
@dskloetd dskloetd requested a review from a team as a code owner July 24, 2024 17:20
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dskloetd dskloetd added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 0b2bfc1 Jul 25, 2024
32 checks passed
@dskloetd dskloetd deleted the kloet/beta-domain branch July 25, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants