Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter text in TextInputForm.spec.ts #6441

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Enter text in TextInputForm.spec.ts #6441

merged 1 commit into from
Feb 17, 2025

Conversation

dskloetd
Copy link
Contributor

Motivation

The required attribute on input elements is not enforced in unit tests.
But after updating to Svelte 5 and related dependency updates, it is required.
This causes TextInputForm.spec.ts to fail because it tries to submit a form without required input.

Changes

  1. Enter some text before trying to submit the form.

Tests

  1. Test still passes.
  2. Test now also passes in build: svelte v5 #6020

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review February 17, 2025 17:28
@dskloetd dskloetd requested a review from a team as a code owner February 17, 2025 17:28
@dskloetd dskloetd enabled auto-merge February 17, 2025 17:28
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dskloetd dskloetd added this pull request to the merge queue Feb 17, 2025
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

auto-merge was automatically disabled February 17, 2025 18:00

Pull Request is not mergeable

Merged via the queue into main with commit 269b07d Feb 17, 2025
32 checks passed
@dskloetd dskloetd deleted the kloet/enter-text branch February 17, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants