fix: tokenData are passed now from AddTokenByNetwork consistent with the chosen network #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the chosen network
peterpeterparker
approved these changes
Jun 21, 2024
| erc20ContractAddress | ||
| }; | ||
| onDestroy(() => { | ||
| tokenData = isNetworkIdICP(network?.id) |
There was a problem hiding this comment.
Can you add a comment about why we do this as it's quite an original pattern?
There was a problem hiding this comment.
check now, I updated the logic, maybe it is better?
|
@peterpeterparker check the new version, maybe it is better? p.s. I tried to do inline, $: tokenData = isNetworkIdICP(network?.id)
? { ledgerCanisterId, indexCanisterId }
: isNetworkIdEthereum(network?.id)
? { erc20ContractAddress }
: {}; but it was giving an error because it was interpreting this as assigning undefined keys |
AntonioVentilii-DFINITY
force-pushed
the
bugfix/token-data-from-add-token-are-consistent
branch
from
9148054 to
ae267e8
Compare
peterpeterparker
approved these changes
Jun 21, 2024
AntonioVentilii-DFINITY
deleted the
bugfix/token-data-from-add-token-are-consistent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To be more consistent with the selected network from the dropdown, the data returned are set when the component is destroyed.
Changes
Prop
tokenDatais defined withonDestroy.