Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove param chainId from saveErc20Contract because is redundant #1521

Merged
merged 1 commit into from
Jun 21, 2024
Merged

chore: remove param chainId from saveErc20Contract because is redundant #1521

merged 1 commit into from
Jun 21, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

Motivation

In service saveErc20Contract, variable chainId can be extracted from param network since is of type EthereumNetwork.

Changes

  • Removed param chainId from saveErc20Contract.
  • Adapted usage of function saveErc20Contract.

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner June 21, 2024 11:12
peterpeterparker
peterpeterparker approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit 097816c into main Jun 21, 2024
7 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the chore/remove-redundant-param-chain-id branch June 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioVentilii-DFINITY @peterpeterparker @AntonioVentilii