feat(frontend): create Storage Setter store #3094
Open
+51
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return { | ||
| set: ({ key, value }) => { | ||
| setStorage({ key, value }); | ||
| set(value); | ||
| }, | ||
| update, |
There was a problem hiding this comment.
I think we should not leak "update" because a consumer can use it and the value does not get saved in the local storage.
Is there another way?
There was a problem hiding this comment.
i tried without it and it is really not what i would do... basically it uses subscribe and not in a functional way... let me think a bit and come back on this
|
|
||
| return newState; | ||
| }), | ||
| resetAll: reset, |
There was a problem hiding this comment.
my idea is that resetAll would reset the entire storage
I can rename it resetStorage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the token group store, we need a mix between the
Storagestore and the map provided by theCertifiedstore. Meaning that we want saved in local storage some thing that isIn this PR we create a new type of
Storagestore that resembles the mapping provided by theCertifiedstore.