Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #3770 , i introduced the field
settings
in theUserProfile
structure. I made it defaulting to avoid missing data in profiles created before the change.However this caused issues with deserialization: the decoding was failing because data were missing obviously.
I had a few options:
UserProfile
differently from the rest --> not worth it since the deserialization should not be affected by how a specific structure changes; furthermore, we DO want to raise errors if the deserialization fails, and not provide a certain defaultChanges
settings
files to be optionalDefault
traitTests
Current tests worked as intended.