-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cyclesledger): Generate Rust types #4023
Conversation
78e4ddd
to
11511f9
Compare
There is a crate for ICRC types, just saying. |
@peterpeterparker I'm aware. It is limited though, whereas this machinery works for all canisters and provides things such as pocket-ic bindings, that the ICRC crate doesn't provide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
P.S.: thanks for the comments, they are really helpful 🙂
Motivation
We would like to auto-generate the bindings used when calling other canisters. We are doing this a step at a time, starting with the cycles ledger, which is an easy choice as it doesn't change much.
Changes
Tests
The binding command is run as part of CI, so we will see if the bindings are out of date.