feat(frontend): add sol api for balance #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loki344
commented
Dec 19, 2024
| * RPC URLs | ||
| */ | ||
| export const SOLANA_RPC_HTTP_URL_MAINNET = `https://solana-mainnet.g.alchemy.com/v2/${import.meta.env.VITE_ALCHEMY_API_KEY}`; | ||
| export const SOLANA_RPC_HTTP_URL_TESTNET = 'https://api.testnet.solana.com'; |
There was a problem hiding this comment.
there is no testnet url in the alchemy dashboard
…alance' into feat(frontend)/add-sol-api-for-balance
|
please review #4033 first |
…l-api-for-balance # Conflicts: # src/frontend/src/sol/types/network.ts
| network: SolanaNetworkType; | ||
| }): Promise<bigint> => { | ||
| assertNonNullish(address); | ||
| assertNonNullish(network); |
There was a problem hiding this comment.
Since the function params are not optional, I don't think we need these asserts.
If address and/or network can be nullish, then we can keep the respective asserts but we need to update the function types accordingly.
DenysKarmazynDFINITY
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
please review #4033 first
Motivation
To abstract the fetching of solana related data we introduce the solana.api.ts. Similar to how bitcoin.api.ts.
Note that this endpoint from solana only returns the sol balance in the wallet.
https://solana.com/docs/rpc/http/getbalance
Changes
Tests
Unit tests provided