Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add external canister method call ui #385

Merged
merged 25 commits into from
Oct 18, 2024

Conversation

keplervital
Copy link
Member

@keplervital keplervital commented Oct 11, 2024

Adds the necessary missing components to surface the method call to an external canister, this also include the configuration of the approvals, policies, etc... for those external method calls.

At the moment the argument and reply constructions is not very helpful because we need to provide hex encoded argument and we get back a UInt8Array back as a response, as a follow up PR i'll give it a try to use candid parser to fetch the public metadata of the canister and have a better DX for that.

I'll mark the PR as ready once the following is completed:

  • Test coverage

Views:

Screenshot 2024-10-11 at 20 34 15
Screenshot 2024-10-11 at 20 32 53
Screenshot 2024-10-11 at 20 32 30
Screenshot 2024-10-11 at 20 32 09
Screenshot 2024-10-11 at 20 31 59

@keplervital keplervital self-assigned this Oct 11, 2024
@olaszakos
Copy link
Contributor

Enable external canister - List for admins by default?

@olaszakos
Copy link
Contributor

Maybe add some info that the validation method must return with { Ok : text; Err : text }?

@keplervital keplervital marked this pull request as ready for review October 17, 2024 18:18
@keplervital keplervital requested review from mraszyk and a team as code owners October 17, 2024 18:18
@keplervital keplervital enabled auto-merge (squash) October 17, 2024 18:18
@keplervital keplervital enabled auto-merge (squash) October 18, 2024 11:37
@keplervital keplervital merged commit f709895 into main Oct 18, 2024
22 checks passed
@keplervital keplervital deleted the kepler/orb-303-ec-proxy-calls branch October 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants