fix: --no-asset-upgrade hangs forever #4089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
dfx deploy --no-asset-upgrade
ordfx canister install --no-asset-upgrade
on an asset canister that is not up to date then dfx hangs forever withWaiting for module change to be reflected in system state tree...
Example:
The problem was that dfx waited for the new wasm hash to show up in the state tree even if the new wasm was not actually installed.
How Has This Been Tested?
Covered by e2e. If the fixed test is run on
master
then it never completes.Checklist: