Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --no-asset-upgrade hangs forever #4089

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Jan 30, 2025

Description

When running dfx deploy --no-asset-upgrade or dfx canister install --no-asset-upgrade on an asset canister that is not up to date then dfx hangs forever with Waiting for module change to be reflected in system state tree...

Example:

% dfx deploy --ic --no-asset-upgrade
Deploying all canisters.
All canisters have already been created.
Building canisters...
[...]
Installing canisters...
Upgrading code for canister fe-app, with canister ID <id>
Waiting for module change to be reflected in system state tree...
Waiting for module change to be reflected in system state tree...
Waiting for module change to be reflected in system state tree...
[keeps waiting forever]

The problem was that dfx waited for the new wasm hash to show up in the state tree even if the new wasm was not actually installed.

How Has This Been Tested?

Covered by e2e. If the fixed test is run on master then it never completes.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested a review from a team as a code owner January 30, 2025 13:47
@sesi200 sesi200 enabled auto-merge (squash) January 30, 2025 14:18
@sesi200 sesi200 merged commit ec749ad into master Jan 30, 2025
298 checks passed
@sesi200 sesi200 deleted the severin/no-asset-upgrade-hangs-forever branch January 30, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants