Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress bars for asset upload #4091

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

ericswanson-dfinity
Copy link
Member

Description

Added spinners to reflect asset synchronization progress. Changed logging from info to debug.

Fixes: https://dfinity.atlassian.net/browse/SDK-1944

Now the output looks like this (while assets are being uploaded)

dfx deploy
Deploying all canisters.
Creating canisters...
Created a wallet canister on the "local" network for user "default" with ID "bnz7o-iuaaa-aaaaa-qaaaa-cai"
scraped-portal-backend canister created with canister id: bkyz2-fmaaa-aaaaa-qaaaq-cai
scraped-portal-frontend canister created with canister id: bd3sg-teaaa-aaaaa-qaaba-cai
Building canisters...
Installing canisters...
Creating UI canister on the local network.
The UI canister on the "local" network is "be2us-64aaa-aaaaa-qaabq-cai"
Installing code for canister scraped-portal-backend, with canister ID bkyz2-fmaaa-aaaaa-qaaaq-cai
Installing code for canister scraped-portal-frontend, with canister ID bd3sg-teaaa-aaaaa-qaaba-cai
WARN: This project does not define a security policy for some assets.
WARN: You should define a security policy in .ic-assets.json5. For example:
WARN: [
WARN:   {
WARN:     "match": "**/*",
WARN:     "security_policy": "standard"
WARN:   }
WARN: ]
WARN: Assets without any security policy: all
WARN: To disable the policy warning, define "disable_security_policy_warning": true in .ic-assets.json5.
⠤ Staged: 164/7828 assets
⠐ Uploaded content: 9499792 bytes                

How Has This Been Tested?

Tested locally

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner January 30, 2025 19:03
@ericswanson-dfinity ericswanson-dfinity enabled auto-merge (squash) January 30, 2025 21:33
@ericswanson-dfinity ericswanson-dfinity merged commit bf4d3f1 into master Jan 30, 2025
297 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/sdk-1944-streamline-canister-install branch January 30, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants