Fix dataclass initialization #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the dataclass initialization so the order of the members of the dataclass doesn't need to match the order of the columns in the CSV file. That adds flexibility when non-required fields with default values needs to be defined last in the dataclass.
Added a test case where the dataclass has a option field and the fields of the dataclass are not in the same other as the columns of the CSV file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a issue where the initialization of dataclass instance was dependent of the order which the columns of the CSV file was defined. For instance, a dataclass defined as:
The definition above required the CSV file to have the first column
nameand the secondemail, causing error or inconsistent data set the the dataclass fields.Related issue: #47