-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] setup gh actions + dependabot #507
Conversation
Thanks a lot, @renefritze. I have a couple of questions and 1 comment:
|
Sure. Changed the PR target.
These two are closely related. I chose the Github registry over dockerhub simply because you wouldn't need to configure any secrets for that. The workflow always has an active github token it uses.
I actually know next to nothing about java build tools, I just used the line from the Dockerfile 😉
You're very welcome. I'll do that. |
@renefritze , About the |
It is added as a prefix, so it would be |
btw, it would be easy to check the maven build against multiple different Java versions, which I think is a very nice thing if you have/want specified a range of supported versions. |
Awesome.
Building against several java versions is something I had on my list. In
fact, I built the latest jars with a slightly higher version of java which
makes not working under java 8. Is it possible to also attach the jars for
each version to a release?
El mié., 13 abr. 2022 3:35 p. m., René Fritze ***@***.***>
escribió:
… btw, it would be easy to check the maven build against multiple different
Java versions, which I think is a very nice thing if you have/want
specified a range of supported versions.
—
Reply to this email directly, view it on GitHub
<#507 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTIGXJWTRYR5CWUKOGNR3VE3EQJANCNFSM5TKH6KDA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I don't have experience with actual Github Releases from Actions. Uploading the produced jars from different jobs as artefacts so you can download them I can do. |
Awesome.
As soon as we fix the es or I modify the integration tests, I will let you
know so we can test this out.
El mié., 13 abr. 2022 4:14 p. m., René Fritze ***@***.***>
escribió:
… I don't have experience with actual Github Releases from Actions.
Uploading the produced jars from different jobs as artefacts so you can
download them I can do.
—
Reply to this email directly, view it on GitHub
<#507 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTIGSKMAUZMZ7OFSM6FG3VE3JEHANCNFSM5TKH6KDA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
*The web service
El mié., 13 abr. 2022 4:20 p. m., Daniel Garijo ***@***.***>
escribió:
… Awesome.
As soon as we fix the es or I modify the integration tests, I will let you
know so we can test this out.
El mié., 13 abr. 2022 4:14 p. m., René Fritze ***@***.***>
escribió:
> I don't have experience with actual Github Releases from Actions.
> Uploading the produced jars from different jobs as artefacts so you can
> download them I can do.
>
> —
> Reply to this email directly, view it on GitHub
> <#507 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALTIGSKMAUZMZ7OFSM6FG3VE3JEHANCNFSM5TKH6KDA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
0708a9d
to
a38616b
Compare
@renefritze the web service is up, and I have committed a small fix (now it's https). If you make this PR final, I will be happy to do a release to test it out. |
a38616b
to
b918012
Compare
b918012
to
17a6c14
Compare
The docker image builds and the maven tests also succeed. Have a look at the action summary |
this should now also work if the repo name isn't all lowercase
38c7ff5
to
4e7c37e
Compare
Thanks a lot. Where can the JARS be seen? I cannot find them. And yes, I agree that adding the Java version would be extremely helpful. |
nvm, I can see them now. This looks awesome, merging! |
This sets up a workflow that builds the package in a configurable environment in one job and builds and pushes the docker image in another. Both currently fail due to #505 and I'll need to rebase this PR once that issue is resolved.
I wanted to use the repository name as the image name to push into ghcr, so my fork's name wouldn't be hardcoded. However image names must be all lowercase. For the time being I just renamed my fork.