Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfixes #690

Merged
merged 3 commits into from
Apr 7, 2024
Merged

bugfixes #690

merged 3 commits into from
Apr 7, 2024

Conversation

SirkoS
Copy link
Contributor

@SirkoS SirkoS commented Apr 6, 2024

Hi,

I fiddled around with Widoco today and caught a few issues I consider bugs. The three commits each target one of the following:

  1. Dark Mode: namespace table still used light mode styling
    • I added the CSS variables in the respective CSS file also for the table style
  2. -noPlaceHolderText overrides manually set paths to abtract etc
    • It could be argued that this is intended behavior but I'd consider this a bug. As a user I only want to prohibit placeholders and not the texts I explicitly set.
    • I changed the behavior so that the config file's pathToAbstract etc supersede -noPlaceHolderText. Now, only the text that are not set are hidden.
  3. When using -uniteSections, some marked JavaScript failed.
    • I assume this was just missed when updating marked at some point. It was already fixed in one place but left open in two other places.

If need be, I can also make this 3 separate pull requests but for me it was easier to include all my fixes into one.

cheers,
Sirko

PS: it would be really nice if these were included in a bugfix release, so I can use it directly in my CI/CD pipelines.
PPS: I'm sorry for the extensive whitespace changes. My editor is just configured to trim upon save.

@dgarijo
Copy link
Owner

dgarijo commented Apr 7, 2024

@SirkoS thanks a lot!!
Next time please push your changes into the develop branch, as it's the latest one. Since I did a release last week these are now in sync, but in the future they may be not.

@dgarijo dgarijo merged commit 358a0e6 into dgarijo:master Apr 7, 2024
4 checks passed
@dgarijo
Copy link
Owner

dgarijo commented Apr 7, 2024

Published a new release with your fixes @SirkoS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants