Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torch backend: use tensordot if available #66

Merged
merged 1 commit into from
Oct 16, 2018
Merged

torch backend: use tensordot if available #66

merged 1 commit into from
Oct 16, 2018

Conversation

jcmgray
Copy link
Collaborator

@jcmgray jcmgray commented Oct 16, 2018

Description

This just makes torch use tensordot if it has it (it was implemented recently here), rather than the einsum based workaround. Haven't noticed much of a performance difference, but probably best practice.

Status

  • Ready to go

@codecov-io
Copy link

Codecov Report

Merging #66 into master will decrease coverage by 0.07%.
The diff coverage is 80%.

dgasmith
dgasmith approved these changes Oct 16, 2018
View reviewed changes
Copy link
Owner

@dgasmith dgasmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dgasmith dgasmith merged commit 02d15b7 into dgasmith:master Oct 16, 2018
@dgasmith dgasmith added this to the v2.3 milestone Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgasmith dgasmith dgasmith approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jcmgray @codecov-io @dgasmith