Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed response code handling #12

Merged
merged 1 commit into from
Sep 30, 2016
Merged

fixed response code handling #12

merged 1 commit into from
Sep 30, 2016

Conversation

aklinkert
Copy link
Contributor

Hey @dghubble ,

thanks for merging the other PR #10. This one adds two checks for http status code 201, which is used by Xing OAUTH1 Api introduced in #10. Would be cool if we could get this one in soon.

We could actually think about allowing some more, but I guess these can also be added when some different APIs require them, yah?

Thanks and greetings from Germany!
Alex

@dghubble
Copy link
Owner

Probably better to allow any 2XX. Now that the response code is checked, I imagine there will be other providers using other codes in the range.

@aklinkert
Copy link
Contributor Author

When having a look onto the status code list I'm wondering if there is a situation where an oauth endpoint would send a status code ! [200, 201]? Guess that's very unlikely since the rest is either no content or partial content, which won't be used here, no?

@dghubble
Copy link
Owner

Yeah, fine. I bet someone else has a weird implementation, but they can raise that concern then. LGTM

@dghubble dghubble merged commit 4385816 into dghubble:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants