Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused code and add linting and pre-commit hooks #503

Merged
merged 19 commits into from
Jun 4, 2024
Merged

chore: remove unused code and add linting and pre-commit hooks #503

merged 19 commits into from
Jun 4, 2024

Conversation

katiestahl
Copy link
Contributor

@katiestahl katiestahl commented May 22, 2024 •
edited
Loading

close #502

@katiestahl katiestahl self-assigned this May 22, 2024
@katiestahl katiestahl added priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced (e.g. f frontend labels May 22, 2024
@katiestahl katiestahl marked this pull request as draft May 22, 2024 22:15
@katiestahl katiestahl marked this pull request as ready for review May 23, 2024 15:54
@katiestahl katiestahl changed the title chore: remove unused code chore: remove unused code and add linting and pre-commit hooks May 23, 2024
@katiestahl katiestahl mentioned this pull request May 24, 2024
Closed
@jsstevenson
Copy link
Contributor

fwiw, I think some of the code from your earlier PRs is in here, but you can consider this as an "approval" for this PR once those other ones are finished and merged into dev

mcannon068nw
mcannon068nw approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@mcannon068nw mcannon068nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for once the other PRs are in

@katiestahl
Copy link
Contributor Author

fwiw, I think some of the code from your earlier PRs is in here, but you can consider this as an "approval" for this PR once those other ones are finished and merged into dev

thanks for catching this. I think I accidentally committed some code when I was playing around with breadcrumbs. I removed it for now.

@katiestahl katiestahl merged commit 1c0c3e2 into dev Jun 4, 2024
3 checks passed
@katiestahl katiestahl deleted the issue-502 branch June 4, 2024 16:31
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcannon068nw mcannon068nw mcannon068nw approved these changes

@acoffman acoffman Awaiting requested review from acoffman

@jsstevenson jsstevenson Awaiting requested review from jsstevenson

Assignees

@katiestahl katiestahl

Labels
cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced (e.g. f frontend priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katiestahl @jsstevenson @mcannon068nw