-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xml/Fact Equals does not consider contextRef #83
Comments
Thank you for getting in touch! I will take a look at this as soon as I can, probably tomorrow. |
Okay, you're not wrong. |
Ok, I think I found the bug and a fix for it. |
Xml/Fact Equals does not consider contextRef. I would not consider these facts duplicates if they do not share context.
`public bool Equals(Fact other)
{
var result = other != null
&& Value.Equals(other.Value, StringComparison.Ordinal)
&& Metric.Equals(other.Metric)
&& Decimals.Equals(other.Decimals, StringComparison.Ordinal);
The text was updated successfully, but these errors were encountered: