Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options: WithBlockCacheSize documentation not correct about BlockCacheSize default value #1844

Closed
ukane-philemon opened this issue Dec 24, 2022 · 0 comments · Fixed by #1909
Closed

options: WithBlockCacheSize documentation not correct about BlockCacheSize default value #1844

ukane-philemon opened this issue Dec 24, 2022 · 0 comments · Fixed by #1909
Labels
area/documentation Documentation related issues.

Comments

@ukane-philemon
Copy link

ukane-philemon commented Dec 24, 2022 •
edited
Loading

What version of Badger is the target?

v3@2103.5 and master

Documentation.

BlockCacheSize: This is set to 256<<20(256Mib?) when using the default options but the WithBlockCacheSize method says the default value is zero.

Additional information.

https://github.com/dgraph-io/badger/blob/main/options.go#L163
https://github.com/dgraph-io/badger/blob/main/options.go#L710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation Documentation related issues.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix the default value in docs dgraph-io/badger
1 participant
@ukane-philemon