-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto: Rename dgraph.badger.v2.pb to badgerpb2 #1314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
Build failed with
Looking into it. |
I'm not sure I agree with this change. Protobuf package names are global and namespaced, so just |
Hey @mvdan, We decided to rename the package to a shorter name after discussing it in hypermodeinc/dgraph#5216 (review) |
🤷 I disagree with all three suggestions for a global namespace. I think you shoud read https://developers.google.com/protocol-buffers/docs/proto3#packages and https://developers.google.com/protocol-buffers/docs/style#packages before making a decision. |
I see that dgraph uses an equally non-unique package name, too: |
Hey @gja, according to the naming convention mentioned here https://developers.google.com/protocol-buffers/docs/style#packages , the badger protobuf package name should be |
This PR renames badger protobuf package from
dgraph.badger.v2.pb
tobadgerpb2
.The
pb.pb.go
file has been regenerated using thepb/gen.sh
script.This change is