[Do not review] Revert Background compression and Block Pool fix #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2020 14:40
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
jarifibrahim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update- I've created separate PRs for each commit. Do not review this PR. I'll close this PR once all the smaller PRs are merged.
#1406
#1407
#1408
#1409
All the PRs mentioned above are reverted.
This PR reverts 4 commits
Background Compression/Decompression - Revert PR #1409
Decompression Pool - Revert PR #1408
Decompression Pool race fix - Revert PR #1407
Builder assert fix (revert PR #1406) (this was reverted because
b.szno longer exists and that assert is no longer valid)The commits mentioned above are being reverted because we have seen some crashes which could be caused by these changes. We haven't been able to reproduce the crashes yet.
Related to #1389, #1388, #1387
Also see https://discuss.dgraph.io/t/current-state-of-badger-crashes/7602
This change is