chore(ci): use pull request target #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
requested review from
akon-dey,
billprovince and
skrdgraph
as code owners
|
Issue we filed coverallsapp/github-action#150 here is resolved now |
skrdgraph
pushed a commit
to dgraph-io/ristretto
that referenced
this pull request
Mar 2, 2023
Goveralls was failing on community PR's. See dgraph-io/badger#1894 Resolves: coverallsapp/github-action#150
skrdgraph
pushed a commit
to dgraph-io/dgraph
that referenced
this pull request
Mar 2, 2023
Goveralls was failing on community PR's. See dgraph-io/badger#1894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secrets are not accessible to community PR's. This is a problem when reporting code coverage, since our goveralls token is stored as a secret, resulting in CI failure. More details about permissions below.
Remark
The github token is unnecessary here. We remove it in the subsequent PR #1896
References