chore(ci): split off coverage workflow #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
changed the title
joshua-goldstein
requested review from
akon-dey,
billprovince and
skrdgraph
as code owners
skrdgraph
previously approved these changes
May 5, 2023
joshua-goldstein
changed the title
added 2 commits
May 5, 2023 16:57
joshua-goldstein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1936 we observed that because we are using
pull_request_targetwithout a specific reference, we are not in fact checking out the PR branch. This PR splits the workflow into two, one only to run badger CI tests, and the other to run tests & report coverage results (using pr_target with the appropriate commit). This has the benefit that any issues with coverage are isolated to one workflow, which we could disable later if problems arise. This does create duplication of compute (all tests run x2) but we are using github hosted runners so we do not pay for this cost. This also aligns with our dgraph repo workflow setup.