Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aix): add aix directory synchronization support #2115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmur
Copy link

@pmur pmur commented Sep 26, 2024

AIX doesn't support a proper flock like linux, but it seems to have enough support for process level file locking using fcntl.

For #2035

Problem

GOOS=aix does not build. AIX does not support a linux-like flock, and does not export unix.Flock.

Solution

Create an AIX specific directory-locking implementation using the AIX version of flock.

@pmur pmur requested a review from a team as a code owner September 26, 2024 20:16
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for badger-docs canceled.

Name Link
🔨 Latest commit ceab022
🔍 Latest deploy log https://app.netlify.com/sites/badger-docs/deploys/67121e7a9919ca000806bdce

@mangalaman93 mangalaman93 force-pushed the murp/aix-sync-support branch from 624ddf8 to 21435d9 Compare October 14, 2024 12:29
AIX doesn't support a proper flock like linux, but it seems
to have enough support for process level file locking using
fcntl.

For dgraph-io#2035
@mangalaman93 mangalaman93 force-pushed the murp/aix-sync-support branch from 21435d9 to ceab022 Compare October 18, 2024 08:38
@pmur
Copy link
Author

pmur commented Oct 31, 2024

Hi, is there something I need to fix in the CL, or is this a CI issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants