Item::ValueCopy

[manishrjain]

Add a ValueCopy function to avoid deadlocks in long running iterations.

Helps solve #315.

---

This change is 

[peterstace]

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.

---

iterator.go, line 89 at r1 (raw file):

}

// ValueCopy returns a copy of the value of the item from the value log.

Would be good to indicate in the comment how dst is used. A user would have to read the code to know that dst will be written to starting at dst[0] rather than being appended to.

---

Comments from Reviewable

[peterstace]

---

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[deepakjois]

---

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

db_test.go, line 1244 at r2 (raw file):

	fmt.Println(dir)
	require.NoError(t, err)
	// defer os.RemoveAll(dir)

Any reason to comment this out?

---

Comments from Reviewable

[manishrjain]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

db_test.go, line 1244 at r2 (raw file):

Previously, deepakjois (Deepak Jois) wrote…

Any reason to comment this out?

DONE. Left during testing.

---

iterator.go, line 89 at r1 (raw file):

Previously, peterstace (Peter Stace) wrote…

Would be good to indicate in the comment how dst is used. A user would have to read the code to know that dst will be written to starting at dst[0] rather than being appended to.

Done.

---

Comments from Reviewable

[deepakjois]

Looks like this has been committed as: b3568eb