Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grpc dependency #233

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

nick-w-nick
Copy link
Contributor

@nick-w-nick nick-w-nick commented Oct 31, 2024

Currently, the grpc dependency is causing the issue shown in issue #231 due to an incompatibility with the most recent version of grpc and any platform other than Linux based on our testing. We've also shown reports that the prebuilt binaries downloaded by gprc are causing massive bloat (nearly a 5x increase in size) to our bundles that are generated with the dependency included.

Upon investigation, we noticed that grpc isn't actually used by anything in the library anymore, and was seemingly added back by mistake during the most recent release, as @grpc/grpc-js is used in place of it.

Sources:
Original PR to remove grpc
PR I made last year, where grpc was not in the list of dependencies at the time, reinforcing the fact that it was added back by mistake
The README of this very repo, which has instructions to install @grpc/grpc-js and not grpc, and here is the PR where that change was made

This PR is to remove the grpc dependency from the package to accomplish the following:

  • remedy the installation issue
  • reduce install sizes
  • get rid of an unused dependency

@nick-w-nick nick-w-nick requested a review from a team as a code owner October 31, 2024 00:59
Copy link
Contributor

@shivaji-kharse shivaji-kharse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me

@shivaji-kharse shivaji-kharse merged commit 55d5d8f into dgraph-io:master Nov 5, 2024
7 checks passed
@nick-w-nick
Copy link
Contributor Author

@shivaji-kharse Thank you for merging the change! I would very much appreciate it if this could make it into a release sometime soon to resolve the issues we are facing with the current version of the library.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants