fix ci and linter

.github/workflows/ci-dgraph-code-coverage.yml

@@ -23,6 +23,8 @@ jobs:
           #!/bin/bash
           # build the test binary
           cd t; go build .
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Clean Up Environment
         run: |
           #!/bin/bash

.github/workflows/ci-dgraph-core-tests.yml

@@ -24,6 +24,8 @@ jobs:
           go-version-file: go.mod
       - name: Install protobuf-compiler
         run: sudo apt update && sudo apt install -y protobuf-compiler
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Check protobuf
         run: |
           cd ./protos

.github/workflows/ci-dgraph-ldbc-tests.yml

@@ -25,6 +25,8 @@ jobs:
           go-version-file: go.mod
       - name: Make Linux Build and Docker Image
         run: make docker-image
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Build Test Binary
         run : |
           #!/bin/bash

.github/workflows/ci-dgraph-load-tests.yml

@@ -24,6 +24,8 @@ jobs:
           go-version-file: go.mod
       - name: Make Linux Build and Docker Image
         run: make docker-image # this internally builds dgraph binary
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Build Test Binary
         run: |
           #!/bin/bash

.github/workflows/ci-dgraph-systest-tests.yml

@@ -32,6 +32,8 @@ jobs:
           git diff --exit-code -- .
       - name: Make Linux Build and Docker Image
         run: make docker-image
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Build Test Binary
         run: |
           #!/bin/bash

.github/workflows/ci-dgraph-tests-arm64.yml

@@ -30,6 +30,8 @@ jobs:
           go mod tidy
           make regenerate
           git diff --exit-code -- .
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Make Linux Build and Docker Image
         run: make docker-image # this internally builds dgraph binary
       - name: Build Test Binary

.github/workflows/ci-dgraph-vector-tests.yml

@@ -32,6 +32,8 @@ jobs:
           git diff --exit-code -- .
       - name: Make Linux Build and Docker Image
         run: make docker-image
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@latest
       - name: Build Test Binary
         run: |
           #!/bin/bash

t/t.go

@@ -276,8 +276,16 @@ func mergeXMLFiles(outputFile string, files []string) error {
 	}
 	defer finalFile.Close()
 
-	finalFile.WriteString(`<?xml version="1.0" encoding="UTF-8"?>`)
-	finalFile.WriteString(`<testsuites>`)
+	testSuiteStr := `<testsuites>`
+	fileWriteErrorMsg := "failed to write string to the file: %v"
+
+	if _, err := finalFile.WriteString(`<?xml version="1.0" encoding="UTF-8"?>`); err != nil {
+		return fmt.Errorf(fileWriteErrorMsg, err)
+	}
+
+	if _, err := finalFile.WriteString(testSuiteStr); err != nil {
+		return fmt.Errorf(fileWriteErrorMsg, err)
+	}
 
 	for _, file := range files {
 		if _, err := os.Stat(file); os.IsNotExist(err) {
@@ -291,13 +299,15 @@ func mergeXMLFiles(outputFile string, files []string) error {
 		}
 
 		// Extract the <testsuite> element from the file and append it
-		parts := strings.SplitN(string(content), "<testsuite", 2)
+		parts := strings.SplitN(string(content), testSuiteStr, 2)
 		if len(parts) > 1 {
-			finalFile.WriteString("<testsuite" + parts[1])
+			finalFile.WriteString(testSuiteStr + parts[1])
 		}
 	}
 
-	finalFile.WriteString(`</testsuites>`)
+	if _, err := finalFile.WriteString(testSuiteStr); err != nil {
+		return fmt.Errorf(fileWriteErrorMsg, err)
+	}
 	return nil
 }