-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect function behaviour when language is not specified #1295
Comments
Problem is visible only for |
Seems that problem is visible for all functions and index types. Previous tests were to trivial - English was the only language used, therefore it was selected as 'any language'. |
eq
functinon doesn't work correctly when no language is passed
This is how we currently do retrieval: Retrieval: We should implement the function in the same manner. |
This PR updates badger to latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314) fd693e4 Support entry version in Write batch (#1310) f9332eb Disable go 1.11 builds on travis (#1306) 09dd2e1 Replace EventLog with Logger (#1203) 4f6763c Add leveled logging (#1249) 30eeec2 Update issue template (#1295) 8097259 Proto: make badger/v2 compatible with v1 (#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284) 6e032c0 Fix race condition in DoesNotHave (#1287) fa94030 Fix Sequence generates duplicate values (#1281) 69f35b3 Add go_package in .proto (#1282) 5f48d42 Disable eventlogging by default (#1285) 4b539b9 Update Project Status in readme.md (#1274) ```
This PR updates badger to latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314) fd693e4 Support entry version in Write batch (#1310) f9332eb Disable go 1.11 builds on travis (#1306) 09dd2e1 Replace EventLog with Logger (#1203) 4f6763c Add leveled logging (#1249) 30eeec2 Update issue template (#1295) 8097259 Proto: make badger/v2 compatible with v1 (#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284) 6e032c0 Fix race condition in DoesNotHave (#1287) fa94030 Fix Sequence generates duplicate values (#1281) 69f35b3 Add go_package in .proto (#1282) 5f48d42 Disable eventlogging by default (#1285) 4b539b9 Update Project Status in readme.md (#1274) ``` (cherry picked from commit 7b37ddb)
This PR updates badger to latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314) fd693e4 Support entry version in Write batch (#1310) f9332eb Disable go 1.11 builds on travis (#1306) 09dd2e1 Replace EventLog with Logger (#1203) 4f6763c Add leveled logging (#1249) 30eeec2 Update issue template (#1295) 8097259 Proto: make badger/v2 compatible with v1 (#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284) 6e032c0 Fix race condition in DoesNotHave (#1287) fa94030 Fix Sequence generates duplicate values (#1281) 69f35b3 Add go_package in .proto (#1282) 5f48d42 Disable eventlogging by default (#1285) 4b539b9 Update Project Status in readme.md (#1274) ``` (cherry picked from commit 7b37ddb)
This PR updates badger to the latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314) fd693e4 Support entry version in Write batch (#1310) f9332eb Disable go 1.11 builds on travis (#1306) 09dd2e1 Replace EventLog with Logger (#1203) 4f6763c Add leveled logging (#1249) 30eeec2 Update issue template (#1295) 8097259 Proto: make badger/v2 compatible with v1 (#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284) 6e032c0 Fix race condition in DoesNotHave (#1287) fa94030 Fix Sequence generates duplicate values (#1281) 69f35b3 Add go_package in .proto (#1282) 5f48d42 Disable eventlogging by default (#1285) 4b539b9 Update Project Status in readme.md (#1274) ``` (cherry picked from commit 7b37ddb)
* Update badger to commit cddf7c03451c (#5216) This PR updates badger to latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314) fd693e4 Support entry version in Write batch (#1310) f9332eb Disable go 1.11 builds on travis (#1306) 09dd2e1 Replace EventLog with Logger (#1203) 4f6763c Add leveled logging (#1249) 30eeec2 Update issue template (#1295) 8097259 Proto: make badger/v2 compatible with v1 (#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284) 6e032c0 Fix race condition in DoesNotHave (#1287) fa94030 Fix Sequence generates duplicate values (#1281) 69f35b3 Add go_package in .proto (#1282) 5f48d42 Disable eventlogging by default (#1285) 4b539b9 Update Project Status in readme.md (#1274) ``` (cherry picked from commit 7b37ddb) * Run go mod tidy * Fix badger options
This PR updates badger to latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (dgraph-io#1314) fd693e4 Support entry version in Write batch (dgraph-io#1310) f9332eb Disable go 1.11 builds on travis (dgraph-io#1306) 09dd2e1 Replace EventLog with Logger (dgraph-io#1203) 4f6763c Add leveled logging (dgraph-io#1249) 30eeec2 Update issue template (dgraph-io#1295) 8097259 Proto: make badger/v2 compatible with v1 (dgraph-io#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (dgraph-io#1284) 6e032c0 Fix race condition in DoesNotHave (dgraph-io#1287) fa94030 Fix Sequence generates duplicate values (dgraph-io#1281) 69f35b3 Add go_package in .proto (dgraph-io#1282) 5f48d42 Disable eventlogging by default (dgraph-io#1285) 4b539b9 Update Project Status in readme.md (dgraph-io#1274) ```
Query:
Query returns no results, but according to docs it should.
The text was updated successfully, but these errors were encountered: