Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the Dgraph version when running live or bulk loader. #2736

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Print the Dgraph version when running live or bulk loader. #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81cf324
Print the Dgraph version when running live or bulk loader.
danielmai Nov 8, 2018
da0877d
Refer to Dgraph Bulk Loader in help doc.
danielmai Nov 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dgraph/cmd/bulk/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func init() {
flag.Int("shufflers", 1,
"Number of shufflers to run concurrently. Increasing this can improve performance, and "+
"must be less than or equal to the number of reduce shards.")
flag.Bool("version", false, "Prints the version of dgraph-bulk-loader.")
flag.Bool("version", false, "Prints the version of Dgraph Bulk Loader.")
flag.BoolP("store_xids", "x", false, "Generate an xid edge for each node.")
flag.StringP("zero", "z", "localhost:5080", "gRPC address for Dgraph zero")
// TODO: Potentially move http server to main.
Expand Down Expand Up @@ -108,8 +108,8 @@ func run() {
ReduceShards: Bulk.Conf.GetInt("reduce_shards"),
}

x.PrintVersion()
if opt.Version {
x.PrintVersion()
os.Exit(0)
}
if opt.RDFDir == "" || opt.SchemaFile == "" {
Expand Down
1 change: 1 addition & 0 deletions dgraph/cmd/live/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ func setup(opts batchMutationOptions, dc *dgo.Dgraph) *loader {
}

func run() error {
x.PrintVersion()
opt = options{
files: Live.Conf.GetString("rdfs"),
schemaFile: Live.Conf.GetString("schema"),
Expand Down